feat: add an install script for easy install #95
Conversation
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
|
Hi @pottekkat, you can check https://github.com/api7/docs/blob/main/.github/workflows/update-s3-and-cloudfront.yaml#L28 for deploying resources on that domain. For this PR, please let Shirui Zhao to assign people to review. Thanks |
|
Great intiative! |
README.md
Outdated
| ``` | ||
| go install github.com/api7/adc@latest |
There was a problem hiding this comment.
For users, it is better to directly download the binary instead of installing with go install. Now I think maybe we should keep both.
There was a problem hiding this comment.
Not really. What's the benefit of keeping an installation approach coupled to a tech stack?
README.md
Outdated
| wget https://github.com/api7/adc/releases/download/v0.5.0/adc_0.5.0_linux_amd64.tar.gz | ||
| tar -zxvf adc_0.5.0_linux_amd64.tar.gz |
There was a problem hiding this comment.
We can use environment variables to specify the version.
|
@AlinsRan Thanks for the review. Checking what the error is. We need to improve error handling. |
| @@ -0,0 +1,84 @@ | |||
| #!/usr/bin/env bash | |||
|
|
|||
| ARCH="$(uname -m)" | |||
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
|
@AlinsRan Is it working now? I tested in a Linux environment as well. If it is working, I will add more error handling to the script.
|
Signed-off-by: Navendu Pottekkat <navendu@apache.org>
Description
Adds an install script that users can just run, and it will install the appropriate version of the ADC binary for macOS and Linux.
TODO:
We need to serve this file similar to how we serve https://run.api7.ai/apisix/quickstart
I suggest this URL https://run.api7.ai/adc/install
Once we do that, users can install ADC by just running
curl -sL https://run.api7.ai/adc/install | sh.@juzhiyuan Can you help with this?
Checklist