Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 2 Authentication Scheme #6

Merged
merged 1 commit into from
Dec 11, 2015
Merged

Conversation

kylef
Copy link
Member

@kylef kylef commented Oct 1, 2015

This pull request extends on the authentication framework (proposed in #4) to provide a base authentication scheme called "OAuth 2".

Dependencies:

@kylef kylef added the draft label Oct 1, 2015

+ Request
+ Headers
+ Authorization (Token)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This unfortunately isn't correct but I'm unsure how to clearly express this. I'm wondering if anyone else has any elegant solutions.

Basically, the Bearer token will be in the Authorization header. It won't be in the header alone which is why this won't work. It will have a suffix like Authorization: Bearer f136803ab9c241079ba0cc1b5d02ee77.

@zdne
Copy link
Contributor

zdne commented Dec 11, 2015

I am merging this to be shelved as a draft. The discussion to continue before going to the "accepted" stage.

zdne added a commit that referenced this pull request Dec 11, 2015
@zdne zdne merged commit c27fad0 into master Dec 11, 2015
@zdne zdne deleted the kylef/authentication-oauth2 branch December 11, 2015 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants