Decode git outputs in order to fix bb stage

[miiila]

bb stage is not working with python3, This PR tries to fix it.

[kylef]

Good catch, @miiila might be a good opportunity to add test coverage for these units to ensure they work on all environments.

If interested you can adapt this test I wrote before:

class GitReleaserTestCase(unittest.TestCase):
    # Initialisation

    def test_errors_when_non_master(self):
        with temp_directory():
            subprocess.check_output('git init', shell=True)

            touch('README.md')
            subprocess.check_output('git add README.md', shell=True)
            subprocess.check_output('git commit -m initial', shell=True)

            subprocess.check_output('git checkout -b kylef', shell=True)

            with self.assertRaises(Exception):
                GitReleaser()

Some of the used utilities by this test:

import os
import tempfile
import shutil
import subprocess


class temp_directory(object):
    def __enter__(self):
        self.working_directory = os.getcwd()
        self.pathname = tempfile.mkdtemp()
        os.chdir(self.pathname)
        return self.pathname

    def __exit__(self, typ, value, traceback):
        os.chdir(self.working_directory)
        shutil.rmtree(self.pathname)


def touch(filename, contents=''):
    path, _ = os.path.split(filename)
    if len(path) > 0:
        os.makedirs(path)

    with open(filename, 'w') as fp:
        fp.write(contents)

[kylef]

This could be simplified by using b'prefix/branch-name' since this would work on both Pythons, on Python 3 it would be bytes and 2 a string.

check_output_mock.return_value = b'prefix/branch-name\n'
assert_equal('prefix/branch-name', get_current_branch())

[miiila]

@kylef thanks for the suggestion. I added (and simplified) tests and removed explicit str conversion. Could you please have a look? Thx.

[Almad]

I still don't know why people hate this :)

[miiila]

I found I have to change it because of the testing. When I patched the check_output and kept import, it was calling an original function rather then a mock.

[Almad]

...right, true

[honzajavorek]

Never met anyone hating this :)

[Almad]

I think you either need to encode here, or in post_message.

[Almad]

...oh, it's going just to slack, so it's probably better to encode at the output layer.

👍