Skip to content
This repository has been archived by the owner on Apr 4, 2019. It is now read-only.

Use sha instead of branch #171

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Use sha instead of branch #171

merged 1 commit into from
Jul 18, 2018

Conversation

honzajavorek
Copy link
Contributor

@honzajavorek honzajavorek commented Jun 29, 2018

My attempt to solve #111. Not tested, this is pure shooting into dark. My idea is we cannot create the deployment using the branch as a ref, because we delete the branch after merging. Instead, we could probably use the sha. Let's see. It's already broken, so this change cannot make it more broken. Hopefully.

The GitHub error is:

{
    'message': 'No ref found for: honzajavorek/clean-up-client',
    'documentation_url': 'https://developer.github.com/v3/repos/deployments/#create-a-deployment'
}

My attempt to solve #111. Not tested, this is pure shooting into dark. My idea is we cannot create the deployment using the branch as a ref, because we delete the branch after merging. Instead, we could probably use the sha. Let's see. It's already broken, so this change cannot make it more broken. Hopefully.
Copy link
Contributor

@abtris abtris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That make sense for me too. LGTM

@XVincentX
Copy link
Contributor

I just received a notification for this by chance.

Let's see. It's already broken, so this change cannot make it more broken.

Best sentence ever.

@honzajavorek
Copy link
Contributor Author

@XVincentX 👋 yeah, because Black Belt is Open Source from the very beginning 😄

@XVincentX
Copy link
Contributor

XVincentX commented Jun 29, 2018 via email

@honzajavorek
Copy link
Contributor Author

Let's see whether I'm gonna be successful in taking over your sorrow of being unsuccessful in fixing this.

@honzajavorek
Copy link
Contributor Author

This got forgotten here 😠 Just got the error again. Merging.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants