Count with the option that params can have no value #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
honzajavorek
force-pushed
the
honzajavorek/no-valueElement
branch
from
f332490
to
3c5c956
Compare
kylef
reviewed
Jan 9, 2019
| module.exports = function compileParams(hrefVariablesElement) { | ||
| const params = {}; | ||
| function getRequired(memberElement) { | ||
| const typeAttributes = memberElement.attributes.getValue('typeAttributes') || []; |
There was a problem hiding this comment.
I wonder, if it makes sense for the minim getValue API To allow you to provide a "default" value. This is similiar to Python's get(prop, default) method.
getValue('typeAttributes', []);@honzajavorek As a Pythonist what do you think?
There was a problem hiding this comment.
Seems like a good idea, especially for arrays. Not sure about values such as null, 0, undefined, and this kind of hell.
kylef
reviewed
Jan 9, 2019
kylef
approved these changes
Jan 9, 2019
|
🎉 This PR is included in version 6.2.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I verified the test is failing without the fix. I revamped the code a bit. It's longer, but hopefully more readable and individual parts more isolated.