Handle array parameters when compiling params #94
Conversation
This commit refactors the parameter compiler to accept Minim Elements directly and internally uses Minim elements. When the given input is not a minim element it will be converted.
kylef
force-pushed
the
kylef/compileParams
branch
from
60367cd
to
67de678
Compare
| parameters[name] = | ||
| required: 'required' in typeAttributes | ||
| default: value.attributes.get('default')?.toValue() | ||
| example: value.toValue() or values[0] |
There was a problem hiding this comment.
The problem lies around the example and default values. For an array these would've been an array of elements. The function returned example and default as an array of elements and thus expansion would expand these array of element objects instead of array of values.
|
Oh, I have Hopefully I'll be able to unite the changes somehow in my PR later on. |
|
|
||
| parameters = compileParams(hrefVariables) | ||
|
|
||
| expect(parameters).to.deep.equal({ |
There was a problem hiding this comment.
We use assert everywhere in Dredd, but that's simple change and can be done later.
|
This will result in a patch release, which should propagate to the latest Dredd automatically. I'd pin higher version of Dredd Transactions in Dredd only when #93 is fixed and the fix released as well. |
Previously, for some legacy reasons, the code for compiling parameters stored
the array of possible values in a structure like this: [{'value': 123}, ...]
@kylef did not know that and did not notice this when rewriting the code
to use the minim library internally, so his changes worked with plain arrays
of values instead: [123, ...] This broke the subsequent code. Interestingly,
neither Dredd Transaction tests or Dredd tests caught this mistake. Especially
Dredd Transactions integration tests were not checking for extraneous warnings
and errors, so the problem slipped through unnoticed. This commit changes the
internal structure for storing the array of values to a plain array.
#94
This PR also refactors the parameter compiler to accept Minim Elements directly and internally uses Minim elements to simplify the logic and to make it easier to fix the bug.
When the given input is not a minim element it will be converted, this conversion is temporary and should be removed once Dredd Transactions completely consumes Minim elements.
Fixes #90