Skip to content

Commit

Permalink
chore: drop Node 6 support
Browse files Browse the repository at this point in the history
Allowing for #1275

BREAKING CHANGE: Dredd does not support Node 6 anymore. Node 6 has a scheduled maintenance end on April 2019.
  • Loading branch information
honzajavorek committed Apr 30, 2019
1 parent d3d77c3 commit 36c3ca7
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 10 deletions.
4 changes: 0 additions & 4 deletions .travis.yml
Expand Up @@ -33,10 +33,6 @@ jobs:
- "pip install --user -r docs/requirements.txt"
script: "npm run ci:docs"

- env: "JOB=node6"
node_js: "6"
script: "npm run ci:test"

- env: "JOB=node8"
node_js: "8"
script: "npm run ci:test"
Expand Down
6 changes: 3 additions & 3 deletions docs/installation.rst
Expand Up @@ -73,20 +73,20 @@ Installing Node.js and npm
- If you’re using `Homebrew <https://brew.sh/>`__, run ``brew install node``
- Otherwise `download Node.js <https://nodejs.org/en/download/>`__ from the official website and install it using the downloaded installer
- Make sure both ``node --version`` and ``npm --version`` work in your Terminal
- Node.js needs to be at least version 6
- Node.js needs to be at least version 8

.. group-tab:: Linux

- `Install Node.js as a system package <https://nodejs.org/en/download/package-manager/>`__
- In case your Linux distribution calls the Node.js binary ``nodejs``, please `follow this advice <https://stackoverflow.com/a/18130296/325365>`__ to have it as ``node`` instead
- Make sure both ``node --version`` and ``npm --version`` work in your Terminal
- Node.js needs to be at least version 6
- Node.js needs to be at least version 8

.. group-tab:: Windows

- `Download Node.js <https://nodejs.org/en/download/>`__ from the official website and install it using the downloaded installer
- Make sure both ``node --version`` and ``npm --version`` work in your Command Prompt
- Node.js needs to be at least version 6
- Node.js needs to be at least version 8

.. note::
If your internet connection is restricted (VPN, firewall, proxy), you need to `configure npm <https://docs.npmjs.com/misc/config#https-proxy>`__:
Expand Down
3 changes: 1 addition & 2 deletions lib/getProxySettings.js
Expand Up @@ -15,8 +15,7 @@ const PROXY_ENV_VARIABLES = ['HTTP_PROXY', 'HTTPS_PROXY', 'NO_PROXY'];
* https://github.com/request/request#user-content-proxies
*/
module.exports = function getProxySettings(env) {
// can't use Object.entries() yet (Node 6 support)
return Object.keys(env).map(name => [name, env[name]])
return Object.entries(env)
.filter(entry => PROXY_ENV_VARIABLES.includes(entry[0].toUpperCase()))
.filter(entry => entry[1] !== '')
.map(entry => `${entry[0]}=${entry[1]}`);
Expand Down
2 changes: 1 addition & 1 deletion package.json
Expand Up @@ -7,7 +7,7 @@
"dredd": "bin/dredd"
},
"engines": {
"node": "^6.9 || >=8"
"node": ">=8"
},
"scripts": {
"docs:lint": "sphinx-build -nW -b linkcheck ./docs ./docs/_build",
Expand Down

0 comments on commit 36c3ca7

Please sign in to comment.