Skip to content

Commit

Permalink
Merge pull request #782 from apiaryio/honzajavorek/remove-hooks-handl…
Browse files Browse the repository at this point in the history
…ers-testing

Remove hooks handlers testing
  • Loading branch information
honzajavorek committed May 16, 2017
2 parents fdd1ce2 + 1795220 commit 41a12cb
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 399 deletions.
11 changes: 0 additions & 11 deletions .github/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -130,17 +130,6 @@ It's default options are in the `test/mocha.opts` file.

Dredd is tested on the [AppVeyor][], a Windows-based CI. There are still [several known limitations][windows issues] when using Dredd on Windows, but the intention is to support it without any compromises. Any help with fixing problems on Windows is greatly appreciated!

### Integration Tests of Hooks Handlers

Every Pull Request spawns dependent integration builds of hook handlers. Thanks
to this, author of the PR can be sure they did not break hook handler
implementations by the changes.

The script `scripts/test-hooks-handlers.coffee` is automatically ran by
Travis CI in one of the jobs in the build matrix every time the tested commit
is part of a PR. Head to the [script code][scripts/test-hooks-handlers.coffee]
to understand how it works. It's thoroughly documented.

### Linting

Dredd uses [coffeelint][] to lint the CoffeeScript codebase. There is a plan
Expand Down
2 changes: 0 additions & 2 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,10 @@ before_install:
# so 'conventional-changelog-lint' could compare commits and lint them: marionebl/conventional-changelog-lint#7
- "git remote set-branches origin master && git fetch && git checkout master && git checkout -"
- "npm -g install npm@latest"
#- "gem install travis" # needed for 'npm run test:hooks-handlers', disabled because of https://github.com/apiaryio/dredd/issues/672
install: "npm install --no-optional"
script:
- "npm run lint"
- "npm run test:coverage"
#- "npm run test:hooks-handlers" # disabled because of https://github.com/apiaryio/dredd/issues/672
after_success:
- "npm run coveralls || true"
- "npm run semantic-release || true"
4 changes: 1 addition & 3 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
"pretest": "npm run build",
"test": "mocha \"test/**/*-test.coffee\"",
"test:coverage": "scripts/coverage.sh",
"test:hooks-handlers": "coffee scripts/test-hooks-handlers.coffee",
"prepublish": "npm run build",
"coveralls": "scripts/coveralls.sh",
"semantic-release": "scripts/semantic-release.sh"
Expand Down Expand Up @@ -69,8 +68,7 @@
"nock": "^9.0.13",
"ps-node": "^0.1.5",
"semantic-release": "^6.3.2",
"sinon": "^2.1.0",
"sync-exec": "^0.6.2"
"sinon": "^2.1.0"
},
"keywords": [
"api",
Expand Down
Loading

0 comments on commit 41a12cb

Please sign in to comment.