New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: decaffinate more test scripts #1070
Conversation
Why would it work on Linux but fail on Windows? π€ |
I didnt see the failing test (on mobile phone), but let me guess itβs the flaky beast we are trying to tame for second time in #1069 |
I don't think that's it. There are actually 32 failures, by the looks of it in places I've touched in this PR. |
I wonder if |
Hmm, interesting. Looking at the failures I can't exactly say what could happen. The code seems to be the same. I suspected some implicit returns missing, I couldn't spot something right away tho, or Windows not being able to find |
It looks like most of the failures (all but one) are related in |
2e2aea9
to
1438707
Compare
ffcffc5
to
35700b6
Compare
cdc89b4
to
461e56d
Compare
2cc4cf7
to
a6bcd30
Compare
A lot smaller in scope but at least the tests pass for what's in here :) |
@realityking I am sorry for the delay, we've had quite a lot of other work on our plates. Thank you for the PR, it's great! |
@michalholasek no worries, I know what it's like π |
π Why this change?
Removing some more cofffeescript bits & pieces.
Main advantage is that eslint lints these new JS files while nothing was linting the coffeescript files.
π Related issues and Pull Requests
This completes the work started in #992
β What didn't I forget?
npm run lint