Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dredd exited without an interesting error message #37

Merged
merged 1 commit into from Feb 4, 2014

Conversation

albertjan
Copy link
Contributor

because we were using '\r' in our blueprint file. This now prints:

info: Beginning Dredd testing...
the use of carriage return(s) '\r' in source data isn't currently supported, please contact makers
undefined

the undefined is because this error doesn't have a stack.

because we were using '\r' in our blueprint file. This now prints: 

info: Beginning Dredd testing...
the use of carriage return(s) '\r' in source data isn't currently supported, please contact makers
undefined

the undefined is because this error doesn't have a stack.
abtris added a commit that referenced this pull request Feb 4, 2014
Dredd exited without an interesting error message
@abtris abtris merged commit 3cfa292 into apiaryio:master Feb 4, 2014
@@ -56,6 +56,7 @@ process.on( 'SIGINT', function() {

dredd.run(function(error, stats){
if (error) {
console.error(error.message);
console.error(error.stack);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be good to wrap this in a conditional?

if (error.stack) {
  console.error(error.stack);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I make update that. Good point!

@albertjan albertjan deleted the patch-1 branch February 4, 2014 14:28
artem-zakharchenko pushed a commit that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants