Making sure transaction.request.body is used only if really present #499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@honzajavorek also linking to this to discover my findings after making it a less strict comparison link |
|
@ddelnano The change in this PR probably doesn't have a large impact on the issues you have, but in my opinion it's wrong and won't work in some cases, so it should be fixed anyway. |
|
@honzajavorek Yea I have dredd-hooks-go working properly as of last night. Will be pushing my changes. I was still not able to figure out what the root of the problem was for the issue I experienced but the work around to prevent dredd crashing was the to make sure the request body had some data in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making this change per @ddelnano's findings in snikch/goodman#5 (comment).