Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the request library instead of custom implementation #734

Merged
merged 1 commit into from
Mar 4, 2017
Merged

Use the request library instead of custom implementation #734

merged 1 commit into from
Mar 4, 2017

Conversation

honzajavorek
Copy link
Contributor

🚀 Why this change?

I'm not sure why Dredd uses custom implementation for requesting the server under test. I experienced some problems with it on Windows. This PR introduces the request library as a way to request the server under test. It should also help in the future to support proxies, because the library supports it out of the box 😎

📝 Related issues and Pull Requests

✅ What didn't I forget?

  • To write docs - N/A
  • To write tests
  • To put Conventional Changelog prefixes in front of all my commits and run npm run lint

@honzajavorek honzajavorek mentioned this pull request Mar 3, 2017
Closed
@honzajavorek honzajavorek requested a review from miiila March 3, 2017 19:27
@honzajavorek honzajavorek mentioned this pull request Mar 3, 2017
Merged
3 tasks
@honzajavorek honzajavorek requested a review from w-vi March 3, 2017 21:43
@honzajavorek
Copy link
Contributor Author

@miiila @w-vi I marked you both as reviewers, but it's a race again - one review is sufficient from whoever comes first 🙂 🏁

w-vi
w-vi approved these changes Mar 4, 2017
View reviewed changes
Copy link
Member

@w-vi w-vi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

request ftw!

@honzajavorek honzajavorek merged commit c8b7123 into master Mar 4, 2017
@honzajavorek honzajavorek deleted the honzajavorek/use-request branch March 4, 2017 11:50
@honzajavorek
Copy link
Contributor Author

honzajavorek commented Mar 4, 2017 •
edited
Loading

@w-vi You're super fast! 🏅 Thank you!

@honzajavorek honzajavorek mentioned this pull request Aug 4, 2017
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@w-vi w-vi w-vi approved these changes

@miiila miiila Awaiting requested review from miiila

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@honzajavorek @w-vi