Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Return correct exit code when tests fail #819

Merged
merged 1 commit into from
Jul 17, 2017

Conversation

michalholasek
Copy link
Contributor

πŸš€ Why this change?

Currently, Dredd returns wrong exit code (O) when test(s) fail (should return 1). This change fixes the problem.

πŸ“ Related issues and Pull Requests

Resolves #818.

βœ… What didn't I forget?

  • To write docs - N/A
  • To write tests - N/A
  • To put Conventional Changelog prefixes in front of all my commits and run npm run lint

Copy link
Contributor

@honzajavorek honzajavorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

πŸ‘ we will continue investigating the problem and we'll follow up with a test etc., but this fixes the issue for now.

@honzajavorek
Copy link
Contributor

Coverage decreased (-0.09%)

This is correct ⬆️ It's hotfix without tests.

@honzajavorek honzajavorek merged commit 92c5ab7 into master Jul 17, 2017
@honzajavorek honzajavorek deleted the michalholasek/cli-exit-code-hotfix branch July 17, 2017 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Errors do not affect CLI exit code
2 participants