This repository has been archived by the owner on Jul 2, 2019. It is now read-only.
Add source maps for YAML parse errors #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -332,6 +332,13 @@ export function parse({minim, source, generateSourceMap}, done) { | |||
| } catch (err) { | |||
| makeAnnotation(Annotation, Link, SourceMap, null, parseResult, | |||
| ANNOTATIONS.CANNOT_PARSE, null, 'Problem loading the input'); | |||
|
|
|||
| if (err.mark) { | |||
| parseResult.content[0].attributes.set('sourceMap', [ | |||
There was a problem hiding this comment.
You may want to use .first()?
danielgtaylor
force-pushed
the
daniel/yaml-error-source-map
branch
from
028d965
to
7bc8c41
Compare
|
@smizell updated based on comments 😄 |
smizell
added a commit
that referenced
this pull request
Dec 11, 2015
Add source maps for YAML parse errors
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two caveats:
cc @smizell