Maps status code validation error to contain real/expected status codes #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| return { | ||
| validator: 'TextDiff', | ||
| realType: APIARY_STATUS_CODE_TYPE, | ||
| expectedType: APIARY_STATUS_CODE_TYPE, | ||
| rawData, | ||
| results: validator.evaluateOutputToResults() | ||
| results: results.map((result) => |
There was a problem hiding this comment.
It's safe to map since the output of evaluateOutputToResults is [] when no errors occurred.
|
I've also updated the tests that didn't seem to assert this validation output previously. |
honzajavorek
approved these changes
May 21, 2019
|
Absolutely agree. Will be covered in #159. Thanks! |
|
🎉 This PR is included in version 3.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds explicit mapping of
statusCodevalidation results to produce expected error messages that include real and expected status codes. Fixes failing tests in Dredd pipeline when using the newest release of Gavel.GitHub