Handle multiple transaction pairs #84
Conversation
BREAKING CHANGE: Skipping empty requests causes bad request-response pairing in the Mock Server. There are probably only legacy reasons why the empty requests are getting skipped and with API Elements we should update.
honzajavorek
force-pushed
the
honzajavorek/multiple-transactions
branch
from
5170dcb
to
35c40a2
Compare
|
I think this should affect only docs and mock server. I'll verify manually the tested blueprint renders correct docs as expected with this change in metamorphoses. |
|
To my surprise, the docs render correctly with this change. |
| "istanbul": "^0.4.5", | ||
| "mocha": "^2.3.0", | ||
| "protagonist": "^1.6.4", | ||
| "protagonist": "^1.6.8", |
There was a problem hiding this comment.
Maybe this can be removed completely in favour of the introduced drafter?
There was a problem hiding this comment.
I think it's a good idea, but I don't want to snowball this PR much. I'll take a look and if the change is straightforward, I'll do it.
There was a problem hiding this comment.
Hmm, there's enough protagonist.parse(..., {type: 'ast'}, ... in the codebase for me not to interfere 😬
|
@JackuB thx! if anything, we'll hopefully learn whether something blows up when I'll make a PR in the core app |
| return element.meta?.classes.indexOf('api') isnt -1 | ||
|
|
||
|
|
||
| describe.only('Multiple Transactions', -> |
There was a problem hiding this comment.
@honzajavorek was the .only a mistake?
This disables all the other tests (which I might add are not passing in master).
There was a problem hiding this comment.
Yes, mistake 😱
Skipping empty requests causes bad request-response pairing in the Apiary Mock Server. There are probably only legacy reasons why the empty requests are getting skipped and with API Elements we should update.
I assumed the versioning scheme from reading 9c6fc1b.
BREAKING CHANGE