Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 10 Support #199

Closed
ejunker opened this issue May 7, 2018 · 2 comments
Closed

Node 10 Support #199

ejunker opened this issue May 7, 2018 · 2 comments

Comments

@ejunker
Copy link

ejunker commented May 7, 2018

I am trying to use Node 10 but get this error.

In file included from ../src/annotation.cc:1:
In file included from ../src/protagonist.h:6:
In file included from ../../nan/nan.h:192:
../../nan/nan_maybe_43_inl.h:112:15: error: no member named 'ForceSet' in 'v8::Object'
  return obj->ForceSet(isolate->GetCurrentContext(), key, value, attribs);
         ~~~  ^

I think it is because it needs to use a newer version of nodejs/nan which supports node 10. It would also be nice to fix any deprecations.

@kylef
Copy link
Member

kylef commented May 10, 2018

We've fixed this in master (tests pass on Node 10 in #200) and I think v2.0.0-pre.0, we're just wrapping up Protagonist 2.0 (Drafter 4.0) so we can get a final 2.0 release out.

@pksunkara
Copy link
Contributor

Releasing 2.0.0-pre.1 fixes this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants