fix slow version resolution #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we were making 100 calls to apibuilder and 100 subprocesses of `git describe`
mbryzek
reviewed
May 17, 2018
bin/apibuilder
Outdated
| end | ||
| end | ||
| found | ||
| versions = client.versions.get_by_application_key(org, application, limit: 100).map { |v| v.version } |
There was a problem hiding this comment.
the api says:
The latest version is the first result returned.
https://app.apibuilder.io/apicollective/apibuilder-api/latest
so I think we can just limit 1
There was a problem hiding this comment.
we are actually hitting this endpoint: https://app.apibuilder.io/apicollective/apibuilder-api/latest#resource-version
and I don't think we can do limit=1 because what if there are new versions in apibuilder that you don't have locally?
mbryzek
approved these changes
May 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we were making 100 calls to apibuilder and 100 subprocesses of
git describe