feat: adding readme suffixes to the manifest #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
t-web
monkey-denky
commented
Jun 7, 2023
templates/consoleReadmeSuffix.md
Outdated
| To learn more about Apify and Actors, take a look at the following resources: | ||
|
|
||
| - [Apify SDK for JavaScript documentation](https://docs.apify.com/sdk/js) | ||
| - [Apify SDK for Python documentation](https://docs.apify.com/sdk/python) |
There was a problem hiding this comment.
Added the Python documentation here in case the template is python-based. This could be dynamic somehow as well but don't think it is worth the effort
mnmkng
requested changes
Jun 7, 2023
mnmkng
reviewed
Jun 9, 2023
mnmkng
requested changes
Jun 9, 2023
Co-authored-by: Ondra Urban <23726914+mnmkng@users.noreply.github.com>
jbartadev
reviewed
Jun 9, 2023
Co-authored-by: Jan Bárta <45016873+jbartadev@users.noreply.github.com>
fnesveda
requested changes
Jun 9, 2023
monkey-denky
commented
Jun 13, 2023
jbartadev
reviewed
Jun 13, 2023
HonzaTuron
approved these changes
Jun 14, 2023
fnesveda
requested changes
Jun 14, 2023
Co-authored-by: Jan Bárta <45016873+jbartadev@users.noreply.github.com>
fnesveda
approved these changes
Jun 14, 2023
|
FYI you can use node-fetch instead https as it's already in package-lock. |
Yeah but only in dev dependencies, this package has no production dependencies |
mnmkng
requested changes
Jun 14, 2023
mnmkng
approved these changes
Jun 14, 2023
jbartadev
approved these changes
Jun 19, 2023
B4nan
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes apify/apify-web#2708