Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create): merge local development instructions into README #372

Merged
merged 10 commits into from Jun 21, 2023

Conversation

monkey-denky
Copy link
Contributor

@monkey-denky monkey-denky commented Jun 7, 2023

If the user uses the template via the CLI we merge localhost specific development instructions found in apify/actor-templates#154 into the README.

closes apify/apify-web#2708

UPDATE

From manifest we get the suffix URL which we will fetch here. This is to avoid publishing and updating the actor-template package. See apify/actor-templates#156

@github-actions github-actions bot added this to the 65th sprint - Web team milestone Jun 7, 2023
@github-actions github-actions bot added the t-web Issues with this label are in the ownership of the web team. label Jun 7, 2023
src/commands/create.js Outdated Show resolved Hide resolved
src/commands/create.js Outdated Show resolved Hide resolved
@monkey-denky monkey-denky marked this pull request as ready for review June 20, 2023 11:53
src/commands/create.js Outdated Show resolved Hide resolved
@monkey-denky monkey-denky requested a review from mnmkng June 20, 2023 17:09
src/lib/create-utils.js Outdated Show resolved Hide resolved
Copy link
Member

@drobnikj drobnikj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one suggest to improve.

src/lib/create-utils.js Outdated Show resolved Hide resolved
@monkey-denky
Copy link
Contributor Author

@drobnikj I followed the CONTRIBUTING.md could you check if everything is ok for the packge pulish as well please? I am not sure about the release version as I saw that you added some breaking change and updated the version to 0.17.0.. should I bump this to 0.17.1 then?

@drobnikj drobnikj merged commit 65a9f80 into master Jun 21, 2023
16 checks passed
@drobnikj drobnikj deleted the feat/template-readme-merging branch June 21, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-web Issues with this label are in the ownership of the web team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants