-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove underscore prefix from objects that are not private #99
Labels
debt
Code quality improvement or decrease of technical debt.
low priority
Low priority issues to be done eventually.
t-tooling
Issues with this label are in the ownership of the tooling team.
Milestone
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
debt
Code quality improvement or decrease of technical debt.
low priority
Low priority issues to be done eventually.
t-tooling
Issues with this label are in the ownership of the tooling team.
Currently, we use the underscore prefix in objects that are imported from other modules (e.g. all objects in https://github.com/apify/apify-client-python/blob/master/src/apify_client/_utils.py) - are not private.
This was intended to let users of the library know, that these objects are for internal usage only.
However, this does not correspond to the usage of underscore prefixes in the Python world. We should remove these prefixes from the non-private objects.
We can still use the underscore prefix in the module names, to let users know, this module is only for internal usage and should not be imported by library users.
The text was updated successfully, but these errors were encountered: