Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underscore prefix from objects that are not private #99

Closed
vdusek opened this issue Jul 25, 2023 · 0 comments · Fixed by #133
Closed

Remove underscore prefix from objects that are not private #99

vdusek opened this issue Jul 25, 2023 · 0 comments · Fixed by #133
Assignees
Labels
debt Code quality improvement or decrease of technical debt. low priority Low priority issues to be done eventually. t-tooling Issues with this label are in the ownership of the tooling team.

Comments

@vdusek
Copy link
Contributor

vdusek commented Jul 25, 2023

Currently, we use the underscore prefix in objects that are imported from other modules (e.g. all objects in https://github.com/apify/apify-client-python/blob/master/src/apify_client/_utils.py) - are not private.

This was intended to let users of the library know, that these objects are for internal usage only.

However, this does not correspond to the usage of underscore prefixes in the Python world. We should remove these prefixes from the non-private objects.

We can still use the underscore prefix in the module names, to let users know, this module is only for internal usage and should not be imported by library users.

@vdusek vdusek added enhancement New feature or request. t-tooling Issues with this label are in the ownership of the tooling team. labels Jul 25, 2023
@vdusek vdusek self-assigned this Jul 25, 2023
@vdusek vdusek added debt Code quality improvement or decrease of technical debt. and removed enhancement New feature or request. labels Aug 4, 2023
@vdusek vdusek added this to the 74nd sprint - Tooling team milestone Oct 6, 2023
@vdusek vdusek added the low priority Low priority issues to be done eventually. label Oct 9, 2023
@vdusek vdusek removed this from the 74nd sprint - Tooling team milestone Oct 18, 2023
@vdusek vdusek added this to the 77th sprint - Tooling team milestone Nov 16, 2023
vdusek added a commit that referenced this issue Dec 2, 2023
vdusek added a commit that referenced this issue Dec 2, 2023
vdusek added a commit that referenced this issue Dec 2, 2023
vdusek added a commit that referenced this issue Dec 2, 2023
vdusek added a commit that referenced this issue Dec 3, 2023
vdusek added a commit that referenced this issue Dec 3, 2023
vdusek added a commit that referenced this issue Dec 3, 2023
vdusek added a commit that referenced this issue Dec 3, 2023
vdusek added a commit that referenced this issue Dec 3, 2023
vdusek added a commit that referenced this issue Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Code quality improvement or decrease of technical debt. low priority Low priority issues to be done eventually. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant