Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate from Flake8 & Autopep8 to Ruff #133

Merged
merged 6 commits into from
Dec 5, 2023
Merged

Migrate from Flake8 & Autopep8 to Ruff #133

merged 6 commits into from
Dec 5, 2023

Conversation

vdusek
Copy link
Contributor

@vdusek vdusek commented Nov 11, 2023

Description

Issues

Problem with typing.get_type_hints()

  • There is a problem on Python 3.8 and 3.9, typing.get_type_hints() throws an error if | is used in the type hint, even if from __future__ import annotations is used.
  • Fortunately, this is not part of our code base and the users of SDK should not have a valid use case for using it for building Actors. However, we use it in the unit tests when mocking methods of ApifyClientAsync in here tests/unit/conftest.py#L81.
  • I implemented a workaround, to make it working, check the commit e81f8ab.

@github-actions github-actions bot added this to the 76th sprint - Tooling team milestone Nov 11, 2023
@github-actions github-actions bot added t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics. labels Nov 11, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vdusek vdusek changed the title Migrate from Flake8 + Autopep8 to Ruff Migrate from Flake8 & Autopep8 to Ruff Nov 13, 2023
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Pull Request Tookit has failed!

Pull request is neither linked to an issue or epic nor labeled as adhoc!

@vdusek vdusek removed this from the 76th sprint - Tooling team milestone Nov 16, 2023
@vdusek vdusek closed this Nov 27, 2023
@vdusek vdusek deleted the add-ruff branch November 27, 2023 11:34
@vdusek vdusek reopened this Nov 27, 2023
@github-actions github-actions bot added this to the 77th sprint - Tooling team milestone Nov 27, 2023
@vdusek vdusek force-pushed the add-ruff branch 10 times, most recently from 0028d34 to 8a96a38 Compare December 3, 2023 19:05
@vdusek vdusek marked this pull request as ready for review December 3, 2023 19:44
Copy link
Member

@jirimoravcik jirimoravcik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

tests/unit/actor/test_actor_dataset.py Outdated Show resolved Hide resolved
tests/unit/actor/test_actor_key_value_store.py Outdated Show resolved Hide resolved
src/apify/_crypto.py Outdated Show resolved Hide resolved
src/apify/_utils.py Outdated Show resolved Hide resolved
@jirimoravcik
Copy link
Member

pls replace methonds with methods

@vdusek vdusek merged commit c55dd7b into master Dec 5, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
t-tooling Issues with this label are in the ownership of the tooling team. tested Temporary label used only programatically for some analytics.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to Ruff (linter & formatter) Remove underscore prefix from objects that are not private
2 participants