fix(browser-pool): respect user options before assigning fingerpints (#…

…2190) Closes #2164
apify · Nov 27, 2023 · f050776 · f050776
1 parent d5aa254
commit f050776
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/packages/browser-pool/src/fingerprinting/hooks.ts b/packages/browser-pool/src/fingerprinting/hooks.ts
@@ -63,8 +63,8 @@ export function createPrePageCreateHook() {
         const { fingerprint } = launchContext.fingerprint!;
 
         if (launchContext.useIncognitoPages && browserPlugin instanceof PlaywrightPlugin && pageOptions) {
-            pageOptions.userAgent = fingerprint.navigator.userAgent;
-            pageOptions.viewport = {
+            pageOptions.userAgent ??= fingerprint.navigator.userAgent;
+            pageOptions.viewport ??= {
                 width: fingerprint.screen.width,
                 height: fingerprint.screen.height,
             };

diff --git a/packages/browser-pool/src/utils.ts b/packages/browser-pool/src/utils.ts
@@ -35,7 +35,7 @@ export type InferBrowserPluginArray<
         // Return the results
         ? Result
         // If the input is a general array of elements (not a tuple), infer it's values type
-        : Input extends (infer U)[]
+        : Input extends readonly (infer U)[]
             // If the values are a union of the plugins
             ? [U] extends [PuppeteerPlugin | PlaywrightPlugin]
                 // Return an array of the union