Skip to content

Commit

Permalink
fix: e2e cheerio-throw-on-ssl-errors (#2154)
Browse files Browse the repository at this point in the history
Ever since Oct 10, the Cheerio SSL errors test has been failing in
Crawlee. This is because before, Crawlee managed to process the
https://no-sct.badssl.com/ website, but now it doesn't (failing with
various errors like "expired certificate" and "unable to verify the
first certificate"). This error now happens even on the
last-known-working commit built with `yarn --immutable`.

Inspired by [the fix from the JS
SDK](apify/apify-sdk-js#247) :) Perhaps
@vladfrangu did you learn something about the error when looking into
it?
  • Loading branch information
barjin committed Nov 2, 2023
1 parent 118515d commit f2d333d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion test/e2e/cheerio-throw-on-ssl-errors/test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -7,5 +7,5 @@ const { stats, datasetItems } = await runActor(testActorDirname);

await expect(stats.requestsFinished > 5 && stats.requestsFinished < 10, 'All requests finished');
await expect(stats.requestsFailed > 20 && stats.requestsFailed < 30, 'Number of failed requests');
await expect(datasetItems.length > 5 && datasetItems.length < 10, 'Number of dataset items');
await expect(datasetItems.length >= 5 && datasetItems.length < 10, 'Number of dataset items');
await expect(validateDataset(datasetItems, ['url', 'title']), 'Dataset items validation');

0 comments on commit f2d333d

Please sign in to comment.