fix: cookie monster is no more #1414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
B4nan
approved these changes
Jul 22, 2022
|
E2E tests running here: https://github.com/apify/crawlee/actions/runs/2718531874 |
|
btw next time try to pick some better PR title, keeping in mind we use them in the changelog :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP - need to add an e2e test tomorrow to ensure everything worked, however this should cleanup the cookie issues once and (hopefully) for allCookies are now (finally, hopefully) handled alongside any possible combo there might be. e2e tests for all 3 pass too 🎉