Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move process name to be the last argument #2

Merged
merged 1 commit into from
Mar 1, 2023

Conversation

satvik007
Copy link

Process/command names can have spaces in them. For the below logic (line 87) to work, process name must be the last argument to the ps call.

while (h.length) {
    row[h.shift()] = h.length ? columns.shift() : columns.join(' ');
}

I can't quite generate a failing test case on demand at the moment but see the below screenshot, many processes created by Firefox have space character in between.

Screenshot from 2023-02-21 19-37-41

@jancurn jancurn requested a review from B4nan February 21, 2023 14:19
Copy link
Member

@jancurn jancurn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@jancurn jancurn merged commit 45de008 into apify:master Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants