Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Code Review and Cleanup #5

Closed
whitlockjc opened this issue Jul 11, 2014 · 0 comments
Closed

Code Review and Cleanup #5

whitlockjc opened this issue Jul 11, 2014 · 0 comments

Comments

@whitlockjc
Copy link
Member

As part of working on #1, a lot of code was kept logically together to make reading the code easier. This means that it might not necessarily be the most performant, for example we might be processing the same object more than once in cases. There are also other places where code could be cleaned up to be more consistent, written to add/avoid extra sanity checks, etc. Now that we have a working test suite covering all known validation needs, we can easily cleanup/refactor without worry of breaking something.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant