Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DevOps] Add CodeClimate style fomatter to use apigee-lint into GitLab CI/CD #429

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

ipierre1
Copy link

Linked to issue : #427

To use full functionnalities on GitLab CI/CD, it would be nice to implement codeclimate formatter to use codequality reports artifact into pipeline job artifacts as bellow:

apigeelint:
  stage: lint
  image: node:12-alpine
  before_script:
    - npm install -g apigeelint
  script:
    - apigeelint -f codeclimate.js > apigeelint-results.json
  artifacts:
    reports:
      codequality:
        - "${CI_PROJECT_DIR}/apigeelint-results.json"

Code Quality of GitLab use CodeClimate json format, with enforcement on fingerprint which is not optional for GitLab CI/CD.

Codequality : https://docs.gitlab.com/ee/ci/testing/code_quality.html
Codeclimate specification : https://github.com/codeclimate/platform/blob/master/spec/analyzers/SPEC.md#data-types

Copy link

google-cla bot commented Mar 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@ssvaidyanathan
Copy link
Collaborator

Thanks for the PR @ipierre1

Can you pls sign the Contributor License Agreement (CLA) so that I can merge and release this version

@ipierre1
Copy link
Author

Hi @ssvaidyanathan ,

Yes, I just sign CLA with my GitHub username. Thanks in advance

@ssvaidyanathan
Copy link
Collaborator

@ipierre1
Copy link
Author

Its still not approved --> https://github.com/apigee/apigeelint/pull/429/checks?check_run_id=22844353512

Sorry I hadn't clicked on the re-scan button, now on the checks page it appears green.

@ssvaidyanathan ssvaidyanathan merged commit 5dfd347 into apigee:main Mar 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants