Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove v1alpha1 protos and related code. #868

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

timburks
Copy link
Contributor

@timburks timburks commented Dec 9, 2022

If needed, this code can be added to registry-experimental (apigee/registry-experimental#120).

Closes #541.

If needed, this code can be added to registry-experimental.
@codecov
Copy link

codecov bot commented Dec 9, 2022

Codecov Report

Merging #868 (149ac71) into main (9261b55) will increase coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #868      +/-   ##
==========================================
+ Coverage   56.73%   56.80%   +0.07%     
==========================================
  Files         106      102       -4     
  Lines        9876     9465     -411     
==========================================
- Hits         5603     5377     -226     
+ Misses       3672     3506     -166     
+ Partials      601      582      -19     
Impacted Files Coverage Δ
cmd/registry/cmd/compute/compute.go 100.00% <ø> (ø)
cmd/registry/cmd/export/sheet.go 9.35% <ø> (+1.75%) ⬆️
cmd/registry/scoring/expression.go 47.61% <ø> (+2.84%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@seaneganx seaneganx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you confirmed that none of this is depended on by packages in registry-experimental?

@timburks
Copy link
Contributor Author

timburks commented Dec 9, 2022

@seaneganx Good question - no, but that's built to a tag, so the effects of this wouldn't show up until the tag is updated. I'll take a look at the code before merging regardless.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Move v1alpha1 protos to registry-experimental
2 participants