Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(go): refactor code for JSON body and query parameters handling #64

Merged
merged 8 commits into from
Mar 14, 2024

Conversation

haseeb-mhr
Copy link
Collaborator

What

perf(go): refactor code for JSON body and query parameters handling

This pull request enhances the functionality of handling json body and oneOf anyOf parameters in From and Query Params.

Why

The changes made in this pull request improve the functionality of handling json body and oneOf anyOf parameters in From and Query Params. It also contains refactoring of existing code.

Type of change

Select multiple if applicable.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause a breaking change)
  • Tests (adds or updates tests)
  • Documentation (adds or updates documentation)
  • Refactor (style improvements, performance improvements, code refactoring)
  • Revert (reverts a commit)
  • CI/Build (adds or updates a script, change in external dependencies)

Dependency Change

N/A

Breaking change

No breaking changes introduced in this PR.

Testing

I run test cases for respective spec file to evaluate the code functionality with the latest changes.

Checklist

  • My code follows the coding conventions
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added new unit tests

@haseeb-mhr haseeb-mhr added enhancement New feature or request priority-high refactoring code enhancements labels Mar 13, 2024
@haseeb-mhr haseeb-mhr self-assigned this Mar 13, 2024
@haseeb-mhr haseeb-mhr linked an issue Mar 13, 2024 that may be closed by this pull request
@haseeb-mhr haseeb-mhr requested review from asadali214 and removed request for Adeel-Ali March 13, 2024 10:31
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Collaborator

@asadali214 asadali214 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@haseeb-mhr haseeb-mhr merged commit 1ab6558 into main Mar 14, 2024
2 checks passed
@haseeb-mhr haseeb-mhr deleted the 50-improve-test-coverage-and-maintainability-grade branch March 18, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority-high refactoring code enhancements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants