Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter APIs by Lifecycle status, 'Clear all' button not available in results view #2037

Closed
bajiat opened this issue Feb 6, 2017 · 3 comments

Comments

@bajiat
Copy link
Contributor

bajiat commented Feb 6, 2017

From @saralavanip on January 24, 2017 10:35

Steps

  1. Visit https://staging.apinf.io (version 0.39.0)
  2. Login as admin/owner
  3. Add APIs with Lifecycle status (eg. Testing)
  4. Click on 'APIs'
  5. Bookmark any APIs
  6. Filter APIs by Lifecycle status clicking on 'filter' icon
  7. Select an option (eg. 'Testing') from drop down menu

Findings

  • Filter APIs by Lifecycle status is successful and they are listed as expected.
  • 'Clear all' button not available in this view
  • If user clicks on 'My APIs' or My Bookmarks without clearing the above results ,it displays empty page.

Screenshot

no_clearall_button_api_filter_results_view

Copied from original issue: Digipalvelutehdas/APIKA#284

@bajiat
Copy link
Contributor Author

bajiat commented Feb 6, 2017

If user clicks on 'My APIs' or My Bookmarks without clearing the above results ,it displays empty page.

This is not a bug. The filter should persist if it has not been cleared. You can find the Clear button by pressing the filter button again.

However, this is not consistent with the Organization page that has a Clear all button.

I would suggest removing the text about filtering and the Clear all button from Organization profile to keep the pages consistent. Any comments from @Nazarah or @apinf/developers ?

@bajiat
Copy link
Contributor Author

bajiat commented Feb 6, 2017

Suggestion from planning meeting:

  • Remove the text about filtering from Organization page
  • Remove Clear all button from Organization page
  • Set the filter button to active on both API Catalog page and on Organization page, when user has selected a filter.

@Nazarah
Copy link
Contributor

Nazarah commented Feb 7, 2017

Wireframes based on the requirements:
When a filtering is applied in organization profile/ API catalog, the filtering button gets highlighted.
This indicates that a filtering has been used to show results.
filteringorganization

filteringapicatalog

@bajiat however, I'd still be favoring to show the filtering criteria text and a clear button in the front view.
User in this way doesn't need to have more than one click to open the filter menu know how the result is being filtered and how to clear up the result. This would be good in the long run when organization/API have multiple criteria to be used for filtering.
The simple solution could be also used to in API catalog by just lowering the set of API cards below than their current position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants