Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/updating filter #2078

Merged
merged 9 commits into from
Feb 7, 2017
Merged

Feature/updating filter #2078

merged 9 commits into from
Feb 7, 2017

Conversation

marla-singer
Copy link
Contributor

Closes #2037

@marla-singer
Copy link
Contributor Author

@apinf/developers Ready for review

@brylie brylie self-assigned this Feb 7, 2017
@brylie
Copy link
Contributor

brylie commented Feb 7, 2017

Rather than designing our own class, lets use the existing active class for Bootstrap buttons. E.g. simply toggle the active class when filters are active. This is semantic, consistent with other UI element on the page, and in alignment with what Bootstrap already provides.

UI showing custom class (with shadow effect)

screenshot_20170207_152702

UI showing active filters with Bootstrap native 'active' class

screenshot_20170207_152928

Rationale

In the second example, above, the UI components have a consistent look and feel. We have less code to consider and maintain, since there is one less CSS class. It may be small in terms of lines of code, but the general points are to:

  • re-use what we already have
  • be consistent
  • look around while we develop

@marla-singer
Copy link
Contributor Author

@brylie Done

@brylie brylie merged commit f929120 into develop Feb 7, 2017
@brylie brylie deleted the feature/updating-filter branch February 7, 2017 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants