Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In catalog, make life-cycle phase icon a link to filtered list #2133

Closed
kyyberi opened this issue Feb 17, 2017 · 16 comments
Closed

In catalog, make life-cycle phase icon a link to filtered list #2133

kyyberi opened this issue Feb 17, 2017 · 16 comments

Comments

@kyyberi
Copy link

kyyberi commented Feb 17, 2017

As a developer I would like to click from catalog "production" label and get filtered list of APIs containing just APIs in production. This is faster than selecting from filtering options.

Wireframes

Currently, APIs with lifecycle status appears like below in catalog (card view)
apicatalognew

On clicking any lifecycle status (including unknown), the API cards get sorted and only cards with that specific lifecycle appears.
Catalog view also indicates how the result is filtered with and a clear all link text.
Clicking the "clear all" should refresh the page and display the default catalog.
apicatalognew4

Same effect should also be possible for tabular view:
apicatalogtablefiltered

@kyyberi kyyberi changed the title In catalog, make life-cycle phase icon a link to filltered list In catalog, make life-cycle phase icon a link to filtered list Feb 17, 2017
@Nazarah
Copy link
Contributor

Nazarah commented Feb 20, 2017

+1

@bajiat
Copy link
Contributor

bajiat commented Feb 20, 2017

@marla-singer Would you be interested?

@marla-singer
Copy link
Contributor

@bajiat Yes

@Nazarah
Copy link
Contributor

Nazarah commented Feb 20, 2017

@bajiat @marla-singer what about table view? Should the same feature be also working for table entries? (i.e. clicking on lifecycle status would sort the entries as well?)

@bajiat
Copy link
Contributor

bajiat commented Feb 22, 2017

@Nazarah Wireframe is ok from my point of view.

For me it would be logical if the table view would work identically.

If the filtering by clicking on the label is implemented for the Catalog, the APIs on the organization page should work identically. I will create a related issue for the implementation for Organization profile page.

@bajiat
Copy link
Contributor

bajiat commented Feb 22, 2017

I have created a related issue for Organization page: #2173. This can be done in next sprint, but you should take into account that the implementation should be reusable.

@bajiat bajiat added ready and removed planning labels Feb 23, 2017
@marla-singer
Copy link
Contributor

marla-singer commented Feb 27, 2017

@kyyberi @Nazarah @bajiat Okay, we will provide users fast filtering. But how does user reset filter options? He/she will click on filter form and click Clear button? But what is profit of filtering via clicking on label if in this case user have to manipulate with filter form as well.

@marla-singer
Copy link
Contributor

@kyyberi @Nazarah @bajiat What is expected if a user clicks on the label with text Unknown?

@Nazarah
Copy link
Contributor

Nazarah commented Feb 27, 2017

@marla-singer The wireframes shows that on adding a filter to the result, a text displays how the result is filtered and a clickable link "Clear All". User can quickly clear the filtered result by clicking the link as well as clearing the result from filter dropmenu.

In my opinion, "Unknown" label should not exist. If an API is not labeled with a lifecycle, it is clear to users from catalog/profile visualization that it is not yet within any lifecycle. keeping a status "Unknown" is itself vague and might create confusion among users.
However, for a quick fix, I suggest to have the similar action for unknown as any other labels. That is clicking unknown label should filter the results with all APIs that are not yet under any specific lifecycle label.
However, I'd suggest everyone to reconsider whether or not we should have an "unknown" status as filter category.

@marla-singer
Copy link
Contributor

The wireframes shows that on adding a filter to the result, a text displays how the result is filtered and a clickable link "Clear All".

@Nazarah Yes, but we deprecated it not long time ago #2037

@Nazarah
Copy link
Contributor

Nazarah commented Feb 27, 2017

I'd suggest introducing that feature again.
if we are implemetning Quick Filtering by clicking liecycle labels, then we should be able to clear out the result as well.
Besides, currently the clearing takes 2 clicks to open the filtering dropmenu and clicking the clear button.
It the cases of quick/manual filtering, the indication should be visible enough to user that the result is now filtered and a wa to clear out te result.
I suggest instead of a button, use link text. In previous implementation, the button text really didn't look good.

@marla-singer
Copy link
Contributor

Not totall agree about "the button text really didn't look good."
I prefer to use a button for this aim judge by semantic mean.

The <a> tag defines a hyperlink, which is used to link from one page to another.
Definition and Usage

The <button> tag defines a clickable button.
Definition and Usage

When a user clicks on Clear all, he expects some action on current page just as link means go to another page. At least we should use decorate the link with dashed line which doesn't expect go to another page

@Nazarah
Copy link
Contributor

Nazarah commented Feb 27, 2017

I leave the decision of button to you @marla-singer :)
Just please make sure it is aligned with other elements and is of perfect size.
All I want is visibility and quick actions filtering.

@marla-singer
Copy link
Contributor

marla-singer commented Feb 28, 2017

@Nazarah I prepared the different decorate for "Clear all". What do you think?
joxi_screenshot_1488271219825

@55
Copy link
Contributor

55 commented Feb 28, 2017

3 or 5, not to overuse color here

@Nazarah
Copy link
Contributor

Nazarah commented Mar 1, 2017

I'd go with 5 and 6.
This is what I had originally in my sketches.
Also while designing the wireframes, I has some discussion with Philippe and he prefers the use of 5 or 6 style to 3 or 4.
besides, in the original implementation, the button didn't look goof in organization view.
So I'd like to go with 5 & 6

@brylie brylie removed the ready label Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants