Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard getChartData method fails when Elastic settings not available #927

Closed
brylie opened this issue Apr 28, 2016 · 9 comments
Closed
Assignees
Labels
Milestone

Comments

@brylie
Copy link
Contributor

brylie commented Apr 28, 2016

While in the process of re-working our settings handling, we get the following error when accessing the dashboard without Elastic settings:

Exception while invoking method 'getChartData' TypeError: Cannot read property 'host' of undefined
     at [object Object].Meteor.methods.getChartData (server/methods/elasticSearch.js:36:44)
@brylie
Copy link
Contributor Author

brylie commented May 12, 2016

@frenchbread we will need to revisit this bug soon. It is affecting @Alapan's work somewhat.

@frenchbread
Copy link
Contributor

There are already couple of checks for settings on elastic-rest package for meteor. Or is this bug on apinf's side?

@brylie
Copy link
Contributor Author

brylie commented May 12, 2016

I think it is in the Apinf getChartData method. Basically, the getChartData method is not properly checking whether the apiUmbrellaConfig object exists prior to using the host attribute. Hence:

Cannot read property 'host' of undefined

@Alapan
Copy link
Contributor

Alapan commented May 15, 2016

@frenchbread @brylie Is there any update on this issue?

@bajiat
Copy link
Contributor

bajiat commented May 23, 2016

@frenchbread Could you take this also as a sprint task?

@frenchbread frenchbread self-assigned this May 23, 2016
@frenchbread
Copy link
Contributor

@bajiat Self-assigned

@bajiat bajiat added ready and removed planning labels May 23, 2016
@bajiat bajiat added this to the Sprint 23 milestone May 23, 2016
@bajiat
Copy link
Contributor

bajiat commented May 26, 2016

@frenchbread Any update on the progress?

@frenchbread
Copy link
Contributor

Can not reproduce this error anymore. Since we depreciated elastic-rest package in #944. PR contains a logic here to check if ES settings are provided. Should we close this issue then?

@brylie
Copy link
Contributor Author

brylie commented May 26, 2016

Closing, since resolved by PR #944

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants