Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve Elastic-REST error after Meteor 1.3 upgrade #949

Closed
bajiat opened this issue May 23, 2016 · 7 comments
Closed

Resolve Elastic-REST error after Meteor 1.3 upgrade #949

bajiat opened this issue May 23, 2016 · 7 comments
Assignees
Labels
Milestone

Comments

@bajiat
Copy link
Contributor

bajiat commented May 23, 2016

TypeError: Object [object Object] has no method 'npmRequire'
at new ElasticRest (packages/frenchbread_elastic-rest/server/elastic-rest.js

OK, our NPM dependency handling has changed, so we probably need to use the ES2015 import syntax in that file.

Suggestion: while solving this, add the package under Apinf organization.

Co-pilot: @brylie

@bajiat
Copy link
Contributor Author

bajiat commented May 23, 2016

@frenchbread Interested?

@frenchbread frenchbread self-assigned this May 23, 2016
@frenchbread
Copy link
Contributor

I'll look into that

@bajiat bajiat added ready and removed planning labels May 23, 2016
@bajiat bajiat added this to the Sprint 23 milestone May 23, 2016
@brylie
Copy link
Contributor

brylie commented May 25, 2016

@frenchbread we are deprecating the elastic-rest package, and moving the code into our core. Basically, we import elasticsearch directly from NPM, and call the client directly in the server/methods/elasticSearch.js getChartData method.

@brylie
Copy link
Contributor

brylie commented May 25, 2016

What are your thoughts on this approach? We have a working solution as of yesterday.

@frenchbread
Copy link
Contributor

@brylie Yep. I've been trying to set up elastic-rest package the whole day now and it turns out that we do not actually need it. elasticsearch - original npm package has a good API in verison 12. I've also written a test app for it and will try to implement it on a dashboard.

@55 55 closed this as completed in #944 May 26, 2016
@55 55 removed the in progress label May 26, 2016
@brylie brylie assigned jykae and unassigned frenchbread May 26, 2016
@brylie
Copy link
Contributor

brylie commented May 26, 2016

@jykae resolved this task with a commit to the Meteor 1.3 upgrade branch.

@frenchbread
Copy link
Contributor

frenchbread commented May 26, 2016

Same as #927.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants