Feature/meteor 1.3 update

[brylie]

Closes #927
Closes #935
Closes #939
Closes #940
Closes #941
Closes #942
Closes #949

Suggested changes

• Update all possible project dependencies, including Meteor
• add package.json for NPM dependency management
• remove unneeded packages
  • switch NPM package handling

[brylie]

@frenchbread, @elnzv, and @jykae will you all please test this PR?

@frenchbread pay particular attention to the dashboard, such as the getChartData method. I have moved the elasticsearch dependency to package.json, and removed the meteorhacks:npm wrapper package.

[55]

Getting this in server console on /dashboard

 Exception while invoking method 'getChartData' TypeError: Object [object Object] has no method 'npmRequire'
     at new ElasticRest (packages/frenchbread_elastic-rest/server/elastic-rest.js:33:1)
     at [object Object].getChartData (server/methods/elasticSearch.js:48:16)
     at maybeAuditArgumentChecks (packages/ddp-server/livedata_server.js:1704:12)
     at packages/ddp-server/livedata_server.js:711:19
     at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
     at packages/ddp-server/livedata_server.js:709:40
     at [object Object]._.extend.withValue (packages/meteor/dynamics_nodejs.js:56:1)
     at packages/ddp-server/livedata_server.js:707:46

[brylie]

TypeError: Object [object Object] has no method 'npmRequire'
at new ElasticRest (packages/frenchbread_elastic-rest/server/elastic-rest.js

OK, our NPM dependency handling has changed, so we probably need to use the ES2015 import syntax in that file.

@frenchbread would you please try to resolve this issue? You can commit directly to this branch.

[jykae]

Could we bring elastic-rest under Apinf organization if not there already? just a side note..

[jykae]

@brylie Got yesterday's Github exception removed by commenting out https://github.com/apinf/api-umbrella-dashboard/blob/develop/server/accounts.js#L60 onLogin handler. From history it looks like this might be some legacy code, was still able to login with Github. Consider cleaning up.

[brylie]

Good catch @jykae

[brylie]

We need to deprecate meteorhacks:npm from any project dependencies. @frenchbread will you see if you can update the elastic-rest module, so that it uses NPM directly?

[frenchbread]

@brylie Yep. Had that idea in mind. Will do.

[brylie]

@frenchbread we are currently refactoring the dashboard code. I will push it to this branch right now.

[brylie]

@frenchbread we have refactored the getChartData server method, which is working as of now. The last part that is giving us trouble, is getting the data into the charts, from within the method callback. Please review, and fix if possible, the client/views/dashboard/charts/charts.js

[jykae]

@brylie @frenchbread
Notes from the evening coder: I think it works now, we just forgot to return the chained result. Added dc from npm

[55]

Getting this error on startup:

=> Errors prevented startup:

   While selecting package versions:
   error: unknown package in top-level dependencies: npm-container

=> Your application has errors. Waiting for file change.

If I remove this package manually it will work correctly.
Should I commit those changes and push it in this branch?

[frenchbread]

Working on #972 #949 since they are blocking this one

[brylie]

@frenchbread please see my comment in #949