Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade and test the recommended security update for JQuery #3515

Conversation

vinaytech
Copy link
Collaborator

@vinaytech vinaytech commented Jun 18, 2018

Closes #3350

Changes

Describe your changes here as a bulleted list:

  • Upgrade and test the recommended security upgrade to JQuery version 3.
  • Changes in package accounts-admin-ui@0.3.3
  • Changes in package twbs:bootstrap to apinf:bootstrap

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @matleppa

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned vinaytech Jun 18, 2018
@ghost ghost added the in progress label Jun 18, 2018
@vinaytech vinaytech changed the title make pull request Upgrade and test the recommended security update for JQuery Jun 19, 2018
@phanimahesh phanimahesh merged commit 50d7bf6 into develop Jul 20, 2018
@ghost ghost removed the Ready for review label Jul 20, 2018
@@ -26,8 +26,10 @@
"js-yaml": "^3.8.1",
"json2csv": "^3.11.1",
"limax": "^1.6.0",
"load-grunt-tasks": "^4.0.0",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was unnecessary, and prevents build on node v4, which is what our meteor uses. @vinaytech could not find any dependency chain that resulted in this being included. Removing this in #3532

@ilarimikkonen ilarimikkonen deleted the apinf/upgrade-and-test-the-recommended-security-update-for-jQuery branch November 30, 2018 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants