Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get rid of load-grunt-tasks #3532

Merged
merged 3 commits into from
Jul 23, 2018
Merged

Get rid of load-grunt-tasks #3532

merged 3 commits into from
Jul 23, 2018

Conversation

vinaytech
Copy link
Collaborator

@vinaytech vinaytech commented Jul 23, 2018

Closes #3532

Changes

Describe your changes here as a bulleted list:

  • remove the package load-grunt-tasks for package.json

Developer checklist

This checklist is to be completed by the PR developer:

  • Alternative solutions were compared/discussed before writing code
    • trade-offs with this solution are considered acceptable
  • Code in this PR adheres to the project styleguide
  • This pull request does not decrease project test coverage
  • If the code changes existing database collection(s), migration has been written
  • If UI texts are added or changed, all texts are internationalized

Reviewer checklist

Reviewed by: @phanimahesh

This list is to be completed by the pull request reviewer:

  • Code works as described/expected
  • Code seems to be error free
    • no browser console errors visible
    • no server console errors visible
    • passes CI build
  • Code is written in a way that promotes maintainability
    • easy to understand
    • well organized
    • follows project coding standards and conventions
    • well documented

@ghost ghost assigned vinaytech Jul 23, 2018
@ghost ghost added the in progress label Jul 23, 2018
@phanimahesh phanimahesh changed the title Grant task issue Get rid of load-grunt-tasks Jul 23, 2018
@phanimahesh phanimahesh merged commit 527c7ee into develop Jul 23, 2018
@ghost ghost removed the in progress label Jul 23, 2018
@phanimahesh phanimahesh deleted the grant-task-issue branch July 23, 2018 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants