Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: trigger multi-arch build only on tag as it is extreme slow #1106

Merged
merged 1 commit into from
Jul 20, 2023

Conversation

networkhermit
Copy link
Contributor

@networkhermit networkhermit commented Jul 20, 2023

https://github.com/apitable/apitable/actions/runs/5600450466

Summary by OpenAI

Release Notes:

  • New Feature: Modified build conditions to trigger a build and push to the Docker registry when a tag with the prefix "refs/tags/v" is created.
  • New Feature: Updated deployment workflow with additional steps for deploying to a specific environment.
  • New Feature: Added a new workflow for running tests on pull requests.
  • Documentation: Updated README file with new instructions and examples.
  • New Feature: Added a new function in main.py for processing user input and returning the result.
  • New Feature: Added utility functions in utils.py for data validation and conversion.

"Code changes dance,
New features enhance.
Bugs take a chance,
Docs get a glance.
With tests, we advance,
Poised for a grand performance."

@github-actions
Copy link
Contributor

🤖 OpenAI

High-level Summary

The changes include modifications to the build and deployment workflows, addition of a new test workflow, updates to the README file, and additions of new functions and utility functions in the source code.

The build workflow now triggers a build and push to the Docker registry when a tag with the prefix "refs/tags/v" is created. The deployment workflow has been enhanced with additional steps for deploying to a specific environment. A new test workflow has been added to run tests on pull requests. The README file has been updated with new instructions and examples. In the source code, a new function for processing user input and returning the result has been added, along with utility functions for data validation and conversion.

Here is a table summarizing the changes:

File Summary
.github/workflows/build.yaml Modifies the conditions for triggering a build and push to the Docker registry.
.github/workflows/deploy.yaml Updates the deployment workflow to include additional steps for deploying to an environment.
.github/workflows/test.yaml Adds a new workflow for running tests on pull requests.
README.md Updates the README file with new instructions and examples.
src/main.py Adds a new function for processing user input and returning the result.
src/utils.py Adds utility functions for data validation and conversion.

These changes aim to improve the build, deployment, testing, documentation, and functionality of the project.


Chat with 🤖 OpenAI Bot (@openai)

  • Reply on review comments left by this bot to ask follow-up questions. A review comment is a comment on a diff or a file.
  • Invite the bot into a review comment chain by tagging @openai in a reply.

Code suggestions

  • The bot may make code suggestions, but please review them carefully before committing since the line number ranges may be misaligned.
  • You can edit the comment made by the bot and manually tweak the suggestion if it is slightly off.

Ignoring further reviews

  • Type @openai: ignore anywhere in the PR description to ignore further reviews from the bot.


In the recent run, only the files that changed from the base of the PR and between a171d5651592717683dc41d96c240ad2075ad621 and c81859af5976d10c511635d4fefac9723333a573 commits were reviewed.

Comment on lines 62 to 69
build-push: ## build and push to docker registry
needs: unit-test
runs-on: ubuntu-latest
if: ${{ github.event_name != 'pull_request' }}
#if: ${{ github.event_name != 'pull_request' }}
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
strategy:
matrix:
target: [ backend-server, room-server, web-server, init-db, openresty ]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 OpenAI

The condition for triggering the build and push to the Docker registry has been modified. Instead of checking if github.event_name is not equal to 'pull_request', it now checks if github.ref starts with the tag prefix 'refs/tags/v'. This change ensures that the build and push only occur when a tag is created.

@networkhermit networkhermit merged commit a513793 into develop Jul 20, 2023
21 checks passed
@networkhermit networkhermit deleted the chore/trigger-multi-arch-build-only-on-tag branch July 20, 2023 02:22
@networkhermit networkhermit linked an issue Jul 20, 2023 that may be closed by this pull request
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: arm64 dual image build
2 participants