Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: trigger multi-arch build only on tag as it is extreme slow #1106

Merged
merged 1 commit into from
Jul 20, 2023
Merged

chore: trigger multi-arch build only on tag as it is extreme slow #1106

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/build.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,8 @@ jobs:
build-push: ## build and push to docker registry
needs: unit-test
runs-on: ubuntu-latest
if: ${{ github.event_name != 'pull_request' }}
#if: ${{ github.event_name != 'pull_request' }}
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
strategy:
matrix:
target: [ backend-server, room-server, web-server, init-db, openresty ]
Comment on lines 62 to 69
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 OpenAI

The condition for triggering the build and push to the Docker registry has been modified. Instead of checking if github.event_name is not equal to 'pull_request', it now checks if github.ref starts with the tag prefix 'refs/tags/v'. This change ensures that the build and push only occur when a tag is created.

Expand All @@ -83,7 +84,8 @@ jobs:
build-push-all-in-one: ## build and push to docker registry
needs: build-push
runs-on: ubuntu-latest
if: ${{ github.event_name != 'pull_request' }}
#if: ${{ github.event_name != 'pull_request' }}
if: ${{ startsWith(github.ref, 'refs/tags/v') }}
env:
APITABLE_DOCKER_HUB_TOKEN: ${{ secrets.APITABLE_DOCKER_HUB_TOKEN }}
steps:
Expand Down
Loading