Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build with MacOSX #503

Closed
remoe opened this issue Jan 21, 2017 · 1 comment
Closed

Can't build with MacOSX #503

remoe opened this issue Jan 21, 2017 · 1 comment
Labels

Comments

@remoe
Copy link
Contributor

remoe commented Jan 21, 2017

I've tried to build the MacOSX binary.

cmake -H. -Bbuild -DCMAKE_BUILD_TYPE=RelWithDebInfo -DCMAKE_PREFIX_PATH=/usr/local/opt/qt5 

The compiler errors was:

apitrace/retrace/glws_cocoa.mm:117:30: error: use of undeclared identifier 'NSWindowStyleMaskTitled'
                  styleMask: NSWindowStyleMaskTitled |
                             ^
apitrace/retrace/glws_cocoa.mm:118:46: error: use of undeclared identifier 'NSWindowStyleMaskClosable'
                                             NSWindowStyleMaskClosable |
                                             ^
apitrace/retrace/glws_cocoa.mm:119:46: error: use of undeclared identifier 'NSWindowStyleMaskMiniaturizable'
                                             NSWindowStyleMaskMiniaturizable
                                             ^
apitrace/retrace/glws_cocoa.mm:345:46: error: use of undeclared identifier 'NSEventMaskAny'
        event = [NSApp nextEventMatchingMask:NSEventMaskAny

To fix this, one can insert this with a MacOSX SDK version prefix:

file: glws_cocoa.mm

#define NSWindowStyleMaskTitled NSTitledWindowMask
#define NSWindowStyleMaskClosable NSClosableWindowMask
#define NSWindowStyleMaskMiniaturizable NSMiniaturizableWindowMask
#define NSEventMaskAny NSAnyEventMask
@jrfonseca
Copy link
Member

This is due to change fe61fd0. By fixing Xcode 8.2 warnings it seems like the build for older Xcode versions broke.

Given Xcode 8.2 is publicly available and a free upgrade, I think it's ok to require it. I'll update the apitrace build to explicitly require Xcode 8.2 and abort when it's not available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants