trace edit: fix crash/corruption in glsl edit #86

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
Contributor

gregory38 commented Jul 3, 2012

Argument elements are allocated twice (new + push_back) which corrupt trace generated by glsledit

@gregory38 gregory38 trace edit: fix crash/corruption in glsl edit
The vector is already allocated. Push_back allocate new elements and previous allocated element remains null pointer.
2f5637b
Contributor

gregory38 commented Jul 3, 2012

Hum I think there is anothers bug.
Adding an empty line in a good shader introduce this kind of issue:
ERROR: 0:1: error(#132) Syntax error: '<' parse error

gregory38 added some commits Jul 6, 2012

@gregory38 gregory38 glsl edit: copy string content e690feb
@gregory38 gregory38 glsl edit: grep multiline error/warning messages
Useful for GL shader errors which spawn multiple lines error message like that:
    >> 2135: warning: Vertex shader failed to compile with the following errors:
    >> ERROR: 1:1: error(#132) Syntax error: 'sdfsafasf' parse error
    >> ERROR: error(#273) 1 compilation errors.  No code generated
68104b8
Owner

zackr commented Jul 6, 2012

Hey, I'm sorry, I missed this pull. I've fixed this error earlier in a week and just pushed it. If you could submit the multiline error/warning as a separate pull that'd be great.

zackr closed this Jul 6, 2012

Contributor

gregory38 commented Jul 6, 2012

Ok I will do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment