trace edit: fix crash/corruption in glsl edit #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The vector is already allocated. Push_back allocate new elements and previous allocated element remains null pointer.
|
Hum I think there is anothers bug. |
Useful for GL shader errors which spawn multiple lines error message like that:
>> 2135: warning: Vertex shader failed to compile with the following errors:
>> ERROR: 1:1: error(apitrace#132) Syntax error: 'sdfsafasf' parse error
>> ERROR: error(apitrace#273) 1 compilation errors. No code generated
|
Hey, I'm sorry, I missed this pull. I've fixed this error earlier in a week and just pushed it. If you could submit the multiline error/warning as a separate pull that'd be great. |
|
Ok I will do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Argument elements are allocated twice (new + push_back) which corrupt trace generated by glsledit