Implement a bunch of additional EGL extensions #877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Latest Khronos headers changed the rects argument to be const, which caused a build failure here.
This extension allows programs to use efficient memory layouts. Ideally both formats and modifiers would get displayed as enums, or at least as hex, but I’m not sure it makes sense to copy the full drm_fourcc.h in there. I have tested this commit against both Weston and Catacomb, two Wayland compositors.
This extension has values which conflict with EGL_KHR_platform_x11, EGL_KHR_platform_gbm and EGL_KHR_platform_wayland, I’m not completely sure how to handle that.
|
Looks good AFAICT. Thanks. |
I have no issues with the commit as is, as it doesn't break anything. Including Another solution is to wrap the FourCC codes with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of these are used or at least linked to by Wayland compositors, this makes it much easier to debug what is going on while debugging those, as otherwise the function calls just don’t get displayed in
apitrace dump.I have tested those against both Weston and Catacomb, on iris, lima and nouveau.
This series is more easily read per commit than as a whole.
I’m not quite sure how to best handle the third commit, which would look much better if I would basically import
drm_fourcc.h, but then keeping it up to date might be an issue.Supersedes #876.