Fix tracing and replaying of Dying Light #906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the command line of the traced application has no arguments besides `argv[0]`, the `cmdlineLen - 1` overflows. With sufficiently high `i` it then eventually causes a buffer overflow and crashes. Fix this by running this loop only when there are actual arguments. Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
Access like `GL_MAP_WRITE_BIT | GL_MAP_INVALIDATE_BUFFER_BIT` reaches the default return, while it shouldn't actually be considered coherent. Signed-off-by: Sviatoslav Peleshko <sviatoslav.peleshko@globallogic.com>
|
Hi @speles . Thanks for your contribution. This PR got lost in my inbox somehow -- I only noticed it now. In the meanwhile, both issues were been fixed independently. I sincerely apologize, to you whom fixed these issues first (and accurately!), and the others who ended up replicating your work unnecessarily... I'll try to do better next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #493
The fixes are in the recent code, so the issue is probably not the exact same as the original reporter had. But tracing and replaying the Dying Light was broken in 11.1 and current master too.
With these patches, I can confirm that both tracing and replaying actually works.