Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to append timestamp to generated trace filename #914

Merged
merged 2 commits into from May 2, 2024

Conversation

lfrb
Copy link
Contributor

@lfrb lfrb commented Apr 25, 2024

This is useful when traces are generated in an automated fashion or handled by some manager auto-restarting the process. This gives more information about the different trace files generated.

TRACE_TIMESTAMP environment variable can be used when using the wrappers directly without using the CLI to start tracing.

lfrb added 2 commits May 2, 2024 10:27
Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
This is useful when traces are generated in an automated fashion
or handled by some manager auto-restarting the process. This gives
more information about the different trace files generated.

`TRACE_TIMESTAMP` environment variable can be used when using the
wrappers directly without using the CLI to start tracing.

Signed-off-by: Louis-Francis Ratté-Boulianne <lfrb@collabora.com>
Copy link
Member

@jrfonseca jrfonseca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@@ -42,7 +42,7 @@ boolOption(const char *option, bool default_) {
strcmp(option, "false") == 0) {
return false;
}
if (strcmp(option, "0") == 0 ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@jrfonseca jrfonseca merged commit d7f3bc1 into apitrace:master May 2, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants