-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix bug when installing in GNU Octave v7.1.0 #95
Conversation
Now is working, few warnings, no errors anymore with
|
Code is looking good. I tested this under Octave 7.1.0 on macOS, and it loads up no problem, and the Would you mind squashing your commits, and rewording the commit message to better describe what this change fixes? In the commits for this PR, I see three separate commits: I'd rather those be a single commit, and instead of saying just "Update load_tablicious.m" etc, they described why the change was made, and what problem it was addressing. Like "Fix library initialization for Octave 7.x" or something like that. Also, in the future, it'd be convenient if you had your changes for PRs on a branch in your fork that wasn't Do me a favor and clean this up git-wise and I'll merge it? Code here looks good; I'd just like to do the merge in a way that both keeps the Tablicious repo's git history tidy, and also preserves author credit for you. |
BTW, thanks for this contribution! This looks like the right approach, and it would have taken me some time to get there myself, and I'm really short on time at the moment, because Reasons. |
Documentation widgets got their functions renamed in GNU Octave v7.1.0 release. This commit updates those functions' names for octave-tablicious. Signed-off-by: Georgios Kourachanis <geo.kourachanis@gmail.com>
Looks good now! I'll re-test this and hopefully get it merged tonight. |
Merged! Thanks for the contribution, and sorry for the slow response on my part. It's been... a week. For several weeks in a row. |
Fixes #91
Some functions' names have had their name changed in "libinterp/corefcn/event-manager.cc" of the GNU Octave source code.
I've initially found out about the issue here (after facing the problem myself, as well) :
https://octave.discourse.group/t/problem-installing-tablicious-package-on-octave-7-1-0/2683/2