Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed broken links for proposed messages. #10

Merged
merged 2 commits into from
Mar 8, 2021
Merged

Fixed broken links for proposed messages. #10

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d9eb4f
Fixed broken links to proposed messages.
valschmidt Mar 8, 2021
f526012
Merge pull request #1 from valschmidt/valschmidt-fixed_broken_msg_links
valschmidt Mar 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions acoustic_msgs/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ from the instrument (estimated altitude and velocity), they differ in what else

### Proposed Message

https://github.com/apl-ocean-engineering/acoustic_msgs/blob/main/msg/Dvl.msg
https://github.com/apl-ocean-engineering/hydrographic_msgs/blob/main/acoustic_msgs/msg/Dvl.msg

This message started with WHOI’s definition, which has been used in
drivers for Nortek and RDI DVLs. There are also corresponding rviz
Expand Down Expand Up @@ -159,7 +159,7 @@ I think that WHOI’s message is an appropriate starting point.

### Proposed Message

https://github.com/apl-ocean-engineering/acoustic_msgs/blob/main/msg/SonarRanges.msg
https://github.com/apl-ocean-engineering/hydrographic_msgs/blob/main/acoustic_msgs/msg/SonarRanges.msg

This message started with WHOI’s definition, which has been used on a Reson,
a Norbit, and a Kongsberg EM2040. I’ve updated some comments and propose
Expand Down Expand Up @@ -199,7 +199,7 @@ different bearings/ranges vs. a 1D array of ranges at different bearings.
ranges, and uses a nested array of SonarBeam message rather than a flat intensities array.

### Proposed Message
https://github.com/apl-ocean-engineering/acoustic_msgs/blob/main/msg/SonarImage.msg
https://github.com/apl-ocean-engineering/hydrographic_msgs/blob/main/acoustic_msgs/msg/SonarImage.msg

This is identical to APL’s updated definition; it has been used with an Oculus M1200D and a Blueview multibeam.

Expand Down