Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility #383

Merged
merged 8 commits into from
Dec 22, 2022
Merged

Accessibility #383

merged 8 commits into from
Dec 22, 2022

Conversation

hannah-martinez
Copy link
Member

@hannah-martinez hannah-martinez commented Dec 15, 2022

  • Add title to every page
  • Fix sizing and scroll issues on different screen sizes for index and about pages
  • Resolve all accessibility issues flagged by the SiteImprove Accessibility Checker

Please check a variety of screen sizes with responsive mode when reviewing to make sure that there's nothing funny happening.

This issue was scoped to the index and about pages because we don't foresee having many active users with accommodations, but please glance through the other pages to make sure that the css changes did not have adverse effects in other places.

Closes #357

Copy link
Contributor

@vrose99 vrose99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- added a few visible titles to some pages for consistency and an overflow issue, but all changes looked good locally + non-proofreading functionality related pages on mobile, too

@hannah-martinez hannah-martinez merged commit ccf7ca4 into staging Dec 22, 2022
@hannah-martinez hannah-martinez deleted the accessibility branch December 22, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants