Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation on LTI 1.3 platform configuration #1205

Merged
merged 1 commit into from
Jun 28, 2023

Conversation

PasiSa
Copy link
Contributor

@PasiSa PasiSa commented Jun 20, 2023

Description

What?

[ANSWER HERE]

Why?

[ANSWER HERE]

How?

[ANSWER HERE]

Fixes #

Testing

Remember to add or update unit tests for new features and changes.

What type of test did you run?

  • Accessibility test using the WAVE extension.
  • Django unit tests.
  • Selenium tests.
  • Other test. (Add a description below)
  • Manual testing.

[ADD A DESCRIPTION ABOUT WHAT YOU TESTED MANUALLY]

Did you test the changes in

  • Chrome
  • Firefox
  • This pull request cannot be tested in the browser.

Think of what is affected by these changes and could become broken

Translation

Programming style

  • Did you follow our style guides?
  • Did you use Python type hinting in all functions that you added or edited? (type hints for function parameters and return values)

Have you updated the README or other relevant documentation?

  • documents inside the doc directory.
  • README.md.
  • Aplus Manual.
  • Other documentation (mention below which documentation).

Is it Done?

  • Reviewer has finished the code review
  • After the review, the developer has made changes accordingly
  • Customer/Teacher has accepted the implementation of the feature

Clean up your git commit history before submitting the pull request!

@markkuriekkinen markkuriekkinen added the type: documentation Documentation needs to be created or maintained label Jun 27, 2023
@markkuriekkinen markkuriekkinen self-requested a review June 27, 2023 17:10
@markkuriekkinen markkuriekkinen self-assigned this Jun 27, 2023
Copy link
Contributor

@markkuriekkinen markkuriekkinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this explains a lot! Would you fix the typos before merging?

doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
@PasiSa
Copy link
Contributor Author

PasiSa commented Jun 28, 2023

Thanks for the comments, they are now address, I believe.

@PasiSa PasiSa assigned markkuriekkinen and unassigned PasiSa Jun 28, 2023
Copy link
Contributor

@markkuriekkinen markkuriekkinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am afraid you missed two of the previous comments.

doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
doc/LTI_1.3_PLATFORM.md Outdated Show resolved Hide resolved
@markkuriekkinen
Copy link
Contributor

Since Github collapses comments in the middle when there are many of those, you need to detect and click the "show" button to see the missing comments.

@PasiSa
Copy link
Contributor Author

PasiSa commented Jun 28, 2023

Ok, maybe now?

Copy link
Contributor

@markkuriekkinen markkuriekkinen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

@markkuriekkinen markkuriekkinen merged commit 58398d9 into apluslms:master Jun 28, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation Documentation needs to be created or maintained
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants