Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided session not selected by default #141

Closed
JManch opened this issue May 17, 2024 · 5 comments · Fixed by #142
Closed

Provided session not selected by default #141

JManch opened this issue May 17, 2024 · 5 comments · Fixed by #142
Assignees
Labels
bug Something isn't working enhancement New feature or request
Milestone

Comments

@JManch
Copy link

JManch commented May 17, 2024

Describe the bug
In the previous version, providing a single session with --sessions would select that session by default. Now, the CMD defaults to - and I have to manually select the session every login.

To Reproduce
Launch tuigreet with tuigreet --sessions <session_dir>

Expected behavior
The provided session should be selected by default

System information:

  • Distribution: NixOS
  • greetd version: 0.9.0
  • tuigreet version: 0.9.0
@apognu
Copy link
Owner

apognu commented May 17, 2024

What do you mean by "providing a single session" ? Providing a directory containing a single desktop file?

@bertini97
Copy link

bertini97 commented May 17, 2024

I would like to add that the same behavior happens when --session is not specified. No session is selected by default, and when you try to log in, it just doesn't. Took me a while to figure this out, it felt like a bug.

It would be cool if tuigreet had a way to pick a default session, as most login managers do. Especially when there is only one desktop file.

Edit: I just realized this was already pointed out in #140.

@apognu apognu self-assigned this May 17, 2024
@apognu apognu added this to the 0.9.1 milestone May 17, 2024
@apognu apognu added bug Something isn't working enhancement New feature or request labels May 17, 2024
@apognu
Copy link
Owner

apognu commented May 17, 2024

This should be fixed on the dev/default-session branch.

I will probably merge this and #140 when I can properly test them (I lost access to my main development computer, so it is a bit harder right now).

@apognu
Copy link
Owner

apognu commented Jun 2, 2024

This is now available in the 0.9.1 version of tuigreet.

@andyrtr
Copy link

andyrtr commented Jun 3, 2024

The new release seems to break --remember-user-session for me here. The last successful session isn't remembered anymore. Is this now intentional?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants